masterofn0n3 / scraper

Backend service for simple google search result scrapper
0 stars 0 forks source link

[Chore] Increase test coverage #4

Open malparty opened 8 months ago

malparty commented 8 months ago

Issue

Automated tests do not cover the core business logic (CSV upload and the keywords retrieval).

Expected

While 100% test coverage is not required for this code challenge, all critical paths of the application should be unit-tested (and, ideally, UI-tested). So the following should be covered:

Note There is a bit of a challenge to implement tests for a service that generates HTTP requests. Hence, it is an expected part of the submission for us to assess your skills in writing challenging tests.

masterofn0n3 commented 8 months ago

Noted! Will add missing test cases for the core business logic.