Latest bukkit version breaks the plugin

masteroftime / Python-Plugin-Loader

55 stars 18 forks source link

Latest bukkit version breaks the plugin #15

Open jomo opened 10 years ago

jomo commented 10 years ago

Commit CraftBukkit/Bukkit 543b253dd8 changes depend, softDepend and loadBefore to use EmptyImmutableList, SingletonImmutableList or RegularImmutableList which cannot be cast to ArrayList.

This causes python loader to break.

intangir commented 10 years ago

which version? its working for me on a 1.7.2 spigot build

i have noticed it takes a longer time to load though, not sure whats causing it

jomo commented 10 years ago

I guess you're using a stable build? Try the latest dev

nightpool commented 10 years ago

Why is this being cast anyway? There doesn't look to be any code that requires an ArrayList, you should really just be using List depend;

EDIT: Which, to be clear, would fix this problem. (Though you should also probably do the same "replace space with underscore" thing Bukkit is now doing)