masterplane8 / F1-League-Management

F1 League Management is an Excel template designed to help F1 2021 league owners track points, penalties, and other league statistics.
26 stars 3 forks source link

[Bugs] Some bugs/issues #4

Closed mantazzo closed 2 years ago

mantazzo commented 2 years ago

Hello, First of all, I want to thank you for the effort to make this table - it's quite powerful! However, on my first proper use I discovered that there are a few small bugs/issues in the table:

mantazzo commented 2 years ago

Following up with some potential improvements/fixes to consider:

Details Driver Race Finishing Positions formula: =IF('Results Tables'!$G$5="Activated";VALUE(IF('Results Tables'!$H8="DNF";21;IF('Results Tables'!$H8="DSQ";21;IF('Results Tables'!$H8="DNP";0;IF('Results Tables'!$H8="BAN";0;IF('Results Tables'!$H8="-";0;'Results Tables'!$H8))))));0) Average Race Finish Position formula: =IFERROR(ROUND(SUMIF(AC4:AZ4;"<>21")/(BA4-COUNTIF(AC4:AZ4;21));2);"-") Quick explanation - SUMIF sums all values of certain range which fit the criteria (sums all fields which are NOT 21 in this case), COUNTIF calculates the number of fields in the range which fit the criteria (counts all fields which ARE 21 in this case). In here, this means that the fields are added and divided by the races scored (Races Participated In, minus Races With DNF/DSQ).

More potential improvements may be possible after looking at Driver Qualy Results section, but for now I'll stop here.

masterplane8 commented 2 years ago

@mantazzo I was trying to fix the Driver Race Finishing Position as you sent that message, funnily enough. I was going to have the 20 value change to however many drivers participated in a particular race. For example, if there were 13 drivers in the first race, the position value for drivers who DNF/DSQ would be 13; however, I run into a circular reference error, so I need to look further into that. As for having the value being 20 in the first place, if a driver does DNF, the lowest position possible is 20th. For all other finishing positions, their position value is referenced elsewhere in the sheet. Setting it to 21 would imply that there were 20 finishers but that would be impossible since 1 DNF'd. Let me know if I'm thinking through that incorrectly.

I also already went through and changed the indexes for Driver Statistics, they'll be fixed in the next update.

masterplane8 commented 2 years ago

Also please don't hesitate to recommend more improvements! So let me know how the Driver Qualy result can be improved too.

masterplane8 commented 2 years ago

I now see what your saying about setting to 21. Adding on to your point, it means that the statistic that shows average finishing position wont include DNF/DSQ, which would solve the problem I stated earlier. I'll change that up for the next update.

mantazzo commented 2 years ago

Yeah I thought using 21 would make sense, because it's a value that will never be used in results (1-20 for finishing, 0 for DNP, so for DNF/DSQ it makes sense to use some other value to make it different), and using the SUMIF/COUNTIF makes Average calculations easier. I guess a value instead of 21 could be used if you prefer...

On another note, I see that in "League Management" section, the Table for Reserve Drivers would not update proper - I checked the formula, and it was referencing some field which seemed to be completely empty, so I adjusted it a bit:

The Change =IF('Reserve Drivers'!C4="";"-";'Reserve Drivers'!C4)

As for ideas with Qualy table part, I was thinking maybe it would be possible to simplify the Race table section by removing the DNF/DSQ check and adding them to the table, however it would break the "races participated in" calculation, so that's out of the question currently.

Finally, I'm not sure how much is this viable, but could you maybe add "the countback" into consideration for driver standings? As an example (only one race results so far), currently I have a driver who finished P10 and got a fastest lap, and in the driver standings he is shown in P9 because he has the same amount of points as the person who finished P9... Not sure if a proper countback would be difficult to make, but just a small idea.

masterplane8 commented 2 years ago

Nice catch on the reserve drivers list. I'll fix that for the next update.

I know of a way to add a the countback function you want; It'll be added to the next update as well.

masterplane8 commented 2 years ago

I believe all issues/suggestions were addressed