mastervanleeuwen / J-TrackGallery

GPS Track Gallery component for Joomla
https://mastervanleeuwen.github.io/J-TrackGallery/
6 stars 0 forks source link

Maps loading problem #35

Open tk5ep opened 1 year ago

tk5ep commented 1 year ago

Hi all,

At first, thanks for this nice package ! I installed it after a upgrade to J4 and it replaced with success the one I used on J3.

To notice : I downloaded the package from the Joomla extension site, but all plugins were missing. I found some infos here and upgraded to RC version found here to retrieve the plugins.

Problems found : 1) Under ADMIN MAPS menu , when I click on any map, I have the following error : "Call to a member function getXml() on null" 2) On the front side, when I click on "Other maps", I only have the map opening, no track displayed. Bug or feature ?

Even if I added the "show_graph" in the link in an article, is it normal that only the track is appearing and not the profile (graph) ? I have to publish the link and follow it to access to this profile. It would be nice to have both track and profile in a glance in an article.

Also, I can't find a link where the user can download the track.

Sorry for this list of questions, but be assured that I like your package and I'm sure it will be optimal once finished ! Kudos to the developer team !

mastervanleeuwen commented 1 year ago

Hi,

Thanks for the nice message.

Please see my replies below.

Hi all,

At first, thanks for this nice package ! I installed it after a upgrade to J4 and it replaced with success the one I used on J3.

To notice : I downloaded the package from the Joomla extension site, but all plugins were missing. I found some infos here and upgraded to RC version found here to retrieve the plugins.

Problems found :

  1. Under ADMIN MAPS menu , when I click on any map, I have the following error : "Call to a member function getXml() on null"

Thanks for reporting this; it seems that this problem was introduced in a recent update of Joomla 4. I have implemented a fix in this version: https://github.com/mastervanleeuwen/J-TrackGallery/releases/download/0.9.34-rc21/com_jtg.zip Could you try it and let me know whether it works?

  1. On the front side, when I click on "Other maps", I only have the map opening, no track displayed. Bug or feature ?

Good question, I think this is a bug; it will take a bit more time to look into this.

In the mean time, if you activate more than one map in the component, a layer switcher will appear and the user can choose which map they prefer. This does not work for Google maps unfortunately, because they don't allow using the openlayers API.

Even if I added the "show_graph" in the link in an article, is it normal that only the track is appearing and not the profile (graph) ? I have to publish the link and follow it to access to this profile. It would be nice to have both track and profile in a glance in an article.

This works on the test web site: https://testing.gta-trek.eu/index.php/nl/plugin . Does the GPS track contain elevation information? You can check this by looking at the track page, to see whether the graph is shown.

Also, I can't find a link where the user can download the track.

To enable this link, you have to configure the permissions so that everyone can download the track. See the instructions here: https://mastervanleeuwen.github.io/J-TrackGallery/configuration.html#permissions

Sorry for this list of questions, but be assured that I like your package and I'm sure it will be optimal once finished ! Kudos to the developer team !

No problem. Please don't hesitate to follow up here if you have additional questions.

Best regards, Marco.

tk5ep commented 1 year ago

Hi Marco,

Thanks for the fast and detailed answers and correction.

1) the patch seems to work, I can now access to the maps. I published 3 maps, but the track does not display a layer switch. EDIT: I also noticed that changing the default map in the track configuration, doesn't change anything in the article, but makes the layer disappear on the track map.

2) OK for the bug in "other maps", no problem for me. Can this be unpublished to clear confusion ?

3) Yes, the gpx file does contain elevation datas, as is it correctly diplayed when clicking on the GPS track link. I also checked in the gpx file. I tried with the Cassopeia default template, no changes. SO not related to the JA-SIMPLI template I'm using.

4) I changed the permissions, and now I can display the download link. Fine !

Here an article on my site to see the effects.

Thanks for the efforts and nice package. Patrick

mastervanleeuwen commented 1 year ago

Hi Patrick,

Just a quick reply on the layer switcher; I just realised that this is a setting that you have to activate in the 'global configuration':

image

For the graph, that for the clarification. The code is the same between the plugin and the main component, so I am surprised that it does not work. Maybe you had a typo? Could you try again adding 'show_graph=1' to the plugin call (see also: https://mastervanleeuwen.github.io/J-TrackGallery/plugin.html)

Best regards, Marco.

tk5ep commented 1 year ago

Hi Marco,

Unfortunately, I had the settings already to the right value.

Here is what I have in my article : {JTRACKGALLERYMAP} id=18, show_graph=1, show_link=1, show_info=1 {/JTRACKGALLERYMAP} I retyped it and added the show_info to see what happens. Nothing more... 😠

Looking at the development tools on both browser I use (Chrome & Edge), no errors apart the following messages, that are present on any page I display (I have to clear this):

[image: errors2.PNG]

BTW, while looking on all other settings, I found out that even if the ratingstars setting is OFF, I do have the stars displayed on the track view. Furthermore I have plenty of the following errors, probably explaining why I don't have the map displayed in the track view. [image: errors.PNG] Regards from Corsica,Patrick

Le mer. 14 déc. 2022 à 10:26, Marco van Leeuwen @.***> a écrit :

Hi Patrick,

Just a quick reply on the layer switcher; I just realised that this is a setting that you have to activate in the 'global configuration': [image: image] https://user-images.githubusercontent.com/23643853/207556965-62b2f738-53a5-4827-a624-2b873f9287ba.png

For the graph, that for the clarification. The code is the same between the plugin and the main component, so I am surprised that it does not work. Maybe you had a typo? Could you try again adding 'show_graph=1' to the plugin call (see also: https://mastervanleeuwen.github.io/J-TrackGallery/plugin.html)

Best regards, Marco.

— Reply to this email directly, view it on GitHub https://github.com/mastervanleeuwen/J-TrackGallery/issues/35#issuecomment-1350713768, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMUDBMWMJI54S3SNOUQUNLWNGHDJANCNFSM6AAAAAAS5NZA6M . You are receiving this because you authored the thread.Message ID: @.***>

-- Patrick Egloff email : @.*** Web page : http://www.egloff.eu

tk5ep commented 1 year ago

Hi Marco, I confirm that changing the default map type for a track doesn't do anything to the track shown in the article BUT does change it in the track view.

The tiles for the second map pointing to https://{a-c}.tiles.wmflabs.org/hikebike/{z}/{x}/{y}.png, don't work at all.

The third one https://tile.thunderforest.com/cycle/{z}/{x}/{y}.png works OK, and I have an API key for this one.

As does the IGN one.

Even with a set of valid layers, the switcher doesn't show on.

Enough work for you for today ! :-)

Greetings,

mastervanleeuwen commented 1 year ago

Hi Patrick,

Thanks for the feedback; I made some tweaks to the code and release a new version: https://github.com/mastervanleeuwen/J-TrackGallery/releases/tag/0.9.34-rc22 could you give that one a try?

Some more replies below:

Hi Marco,

Thanks for the fast and detailed answers and correction.

  1. the patch seems to work, I can now access to the maps. I published 3 maps, but the track does not display a layer switch. EDIT: I also noticed that changing the default map in the track configuration, doesn't change anything in the article, but makes the layer disappear on the track map. Good point, this should be fixed now.

  2. OK for the bug in "other maps", no problem for me. Can this be unpublished to clear confusion ? I agree that it does not seem to be very useful, so I have removed this.

  3. Yes, the gpx file does contain elevation datas, as is it correctly diplayed when clicking on the GPS track link. I also checked in the gpx file.

This is also fixed; it turns out that the graphs were not shown if they were turned off in the settings for the main component. I have now changed this, so that you can override this by setting show_graph=1 in the plugin.

Best regards,

Marco.

I tried with the Cassopeia default template, no changes. SO not related to the JA-SIMPLI template I'm using.

  1. I changed the permissions, and now I can display the download link. Fine !

Here an article on my site to see the effects.

Thanks for the efforts and nice package. Patrick

tk5ep commented 1 year ago

Great! I'm actually not at home and will be back on Dec 21. I will try this newer version and give you a feedback.

Thanks,

Le sam. 17 déc. 2022 à 15:19, Marco van Leeuwen @.***> a écrit :

Hi Patrick,

Thanks for the feedback; I made some tweaks to the code and release a new version: https://github.com/mastervanleeuwen/J-TrackGallery/releases/tag/0.9.34-rc22 could you give that one a try?

Some more replies below:

Hi Marco,

Thanks for the fast and detailed answers and correction.

  1. the patch seems to work, I can now access to the maps. I published 3 maps, but the track does not display a layer switch. EDIT: I also noticed that changing the default map in the track configuration, doesn't change anything in the article, but makes the layer disappear on the track map. Good point, this should be fixed now.

  2. OK for the bug in "other maps", no problem for me. Can this be unpublished to clear confusion ? I agree that it does not seem to be very useful, so I have removed this.

  3. Yes, the gpx file does contain elevation datas, as is it correctly diplayed when clicking on the GPS track link. I also checked in the gpx file.

This is also fixed; it turns out that the graphs were not shown if they were turned off in the settings for the main component. I have now changed this, so that you can override this by setting show_graph=1 in the plugin.

Best regards,

Marco.

I tried with the Cassopeia default template, no changes. SO not related to the JA-SIMPLI template I'm using.

  1. I changed the permissions, and now I can display the download link. Fine !

Here an article on my site to see the effects. https://www.egloff.eu/index.php?option=com_content&view=article&id=251:capu-di-u-vitullu-tk-tk-063&catid=28&Itemid=1334&lang=en

Thanks for the efforts and nice package. Patrick

— Reply to this email directly, view it on GitHub https://github.com/mastervanleeuwen/J-TrackGallery/issues/35#issuecomment-1356278138, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMUDBITGV3T2VOO36MOJ2TWNXDXVANCNFSM6AAAAAAS5NZA6M . You are receiving this because you authored the thread.Message ID: @.***>

tk5ep commented 1 year ago

Hi Marco,

I'm back home and updated with your latest release.

The graph is correctly displayed now ! 👍 BTW, I didn't have it disabled in the main parameters.

I installed the complete package and got an error concerning the italian language that was missing, or something like that. I didn't copy the error message. sorry

The map switcher doesn't appear for the moment.

I will make further tests and will keep you informed.

Thanks and greetings, patrick

Le sam. 17 déc. 2022 à 15:19, Marco van Leeuwen @.***> a écrit :

Hi Patrick,

Thanks for the feedback; I made some tweaks to the code and release a new version: https://github.com/mastervanleeuwen/J-TrackGallery/releases/tag/0.9.34-rc22 could you give that one a try?

Some more replies below:

Hi Marco,

Thanks for the fast and detailed answers and correction.

  1. the patch seems to work, I can now access to the maps. I published 3 maps, but the track does not display a layer switch. EDIT: I also noticed that changing the default map in the track configuration, doesn't change anything in the article, but makes the layer disappear on the track map. Good point, this should be fixed now.

  2. OK for the bug in "other maps", no problem for me. Can this be unpublished to clear confusion ? I agree that it does not seem to be very useful, so I have removed this.

  3. Yes, the gpx file does contain elevation datas, as is it correctly diplayed when clicking on the GPS track link. I also checked in the gpx file.

This is also fixed; it turns out that the graphs were not shown if they were turned off in the settings for the main component. I have now changed this, so that you can override this by setting show_graph=1 in the plugin.

Best regards,

Marco.

I tried with the Cassopeia default template, no changes. SO not related to the JA-SIMPLI template I'm using.

  1. I changed the permissions, and now I can display the download link. Fine !

Here an article on my site to see the effects. https://www.egloff.eu/index.php?option=com_content&view=article&id=251:capu-di-u-vitullu-tk-tk-063&catid=28&Itemid=1334&lang=en

Thanks for the efforts and nice package. Patrick

— Reply to this email directly, view it on GitHub https://github.com/mastervanleeuwen/J-TrackGallery/issues/35#issuecomment-1356278138, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMUDBITGV3T2VOO36MOJ2TWNXDXVANCNFSM6AAAAAAS5NZA6M . You are receiving this because you authored the thread.Message ID: @.***>

-- Patrick Egloff email : @.*** Web page : http://www.egloff.eu

mastervanleeuwen commented 1 year ago

Hi Patrick,

I have one more question/suggestion for the layer switcher: it is only shown when you have multiple maps enabled in the maps configuration menu in the backend. Could it be that you have only one map enabled?

I also do not see the layer switcher appear in the standard track view https://www.egloff.eu/index.php?option=com_jtg&view=track&id=19&lang=en ...

Best regards, Marco.

tk5ep commented 1 year ago

Hi Marco,

Yes, I do have more than one map active. Please see on both pictures I attached.

Did you make any update since last exchanges ?

Regards, Patrick

Le mar. 24 janv. 2023 à 23:15, Marco van Leeuwen @.***> a écrit :

Hi Patrick,

I have one more question/suggestion for the layer switcher: it is only shown when you have multiple maps enabled in the maps configuration menu in the backend. Could it be that you have only one map enabled?

I also do not see the layer switcher appear in the standard track view https://www.egloff.eu/index.php?option=com_jtg&view=track&id=19&lang=en ...

Best regards, Marco.

— Reply to this email directly, view it on GitHub https://github.com/mastervanleeuwen/J-TrackGallery/issues/35#issuecomment-1402763827, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMUDBOY5WUNEM6JSA23P2DWUBH63ANCNFSM6AAAAAAS5NZA6M . You are receiving this because you authored the thread.Message ID: @.***>

-- Patrick Egloff email : @.*** Web page : http://www.egloff.eu

tk5ep commented 1 year ago

By the way, is there an option to have other maps tiles like those published by Jawg ? : https://www.jawg.io/ https://www.jawg.io/

I use them on my webpage : https://www.egloff.eu/qralocator/

Thanks,

Le mar. 24 janv. 2023 à 23:15, Marco van Leeuwen @.***> a écrit :

Hi Patrick,

I have one more question/suggestion for the layer switcher: it is only shown when you have multiple maps enabled in the maps configuration menu in the backend. Could it be that you have only one map enabled?

I also do not see the layer switcher appear in the standard track view https://www.egloff.eu/index.php?option=com_jtg&view=track&id=19&lang=en ...

Best regards, Marco.

— Reply to this email directly, view it on GitHub https://github.com/mastervanleeuwen/J-TrackGallery/issues/35#issuecomment-1402763827, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMUDBOY5WUNEM6JSA23P2DWUBH63ANCNFSM6AAAAAAS5NZA6M . You are receiving this because you authored the thread.Message ID: @.***>

-- Patrick Egloff email : @.*** Web page : http://www.egloff.eu

mastervanleeuwen commented 1 year ago

Dear Patrick,

Thanks for the follow-up. I had a look at the page source for this track: https://www.egloff.eu/index.php?option=com_jtg&view=track&id=19&lang=en

I see that only one map layer is initialised:

  jtgMap.addControl(new ol.control.MousePosition( {coordinateFormat: ol.coordinate.createStringXY(4), projection: 'EPSG:4326' } ));
  jtgMap.addControl(new ol.control.ZoomSlider());
  jtgAddMapLayer(0,'','','OSM Mapnik', true);

I think that only happens when only a single map layer is currently active (note that you can switch whether a map is active or not in the map settings for each map).

I have been adding various fixes and updates in the development version, so it is probably worth updating to the latest version: https://www.egloff.eu/index.php?option=com_jtg&view=track&id=19&lang=en

Concerning your other question: yes, I think it should be possible to use jawg maps. Looking at their documentation, here:

https://www.jawg.io/docs/integration/leaflet/simple-map

They use the openstreetmap format, so you can create a new map with this URL for the tile server in the field 'OL Parameters':

https://tile.jawg.io/jawg-sunny/{z}/{x}/{y}.png?access-token=${accessToken}

where you need to fill in your access token.

tk5ep commented 1 year ago

Hi Marco,

Very weird. As you could see, I have more than one map activated.

I could add a new Jawg map : https://tile.jawg.io/jawg-terrain/{z}/{x}/{y}.png?access-token=bLNd8aiAa9WsSkpRTCMnnkKOrulBUf9fw6d8aldm0PZ1W7sehZ4i0AVnhWVzWP9O

You made a wrong paste and instead of the link to the update, you gave me the link to my page. 😁 The latest update I could find on your Github is the 0.9-34-rc25 I've installed, but don't see any changes. FYI, I installed the complete package and got this error :

JInstaller: :Install: File does not exist [ROOT][TMP]/install_63d21c0a2c603/install_63d21c0a830fa/language/it-IT/it-IT.mod_jtrackgallery_latest.ini I hope this helps? Thanks,

Le mer. 25 janv. 2023 à 22:01, Marco van Leeuwen @.***> a écrit :

Dear Patrick,

Thanks for the follow-up. I had a look at the page source for this track: https://www.egloff.eu/index.php?option=com_jtg&view=track&id=19&lang=en

I see that only one map layer is initialised:

jtgMap.addControl(new ol.control.MousePosition( {coordinateFormat: ol.coordinate.createStringXY(4), projection: 'EPSG:4326' } ));

jtgMap.addControl(new ol.control.ZoomSlider());

jtgAddMapLayer(0,'','','OSM Mapnik', true);

I think that only happens when only a single map layer is currently active (note that you can switch whether a map is active or not in the map settings for each map).

I have been adding various fixes and updates in the development version, so it is probably worth updating to the latest version: https://www.egloff.eu/index.php?option=com_jtg&view=track&id=19&lang=en

Concerning your other question: yes, I think it should be possible to use jawg maps. Looking at their documentation, here:

https://www.jawg.io/docs/integration/leaflet/simple-map

They use the openstreetmap format, so you can create a new map with this URL for the tile server in the field 'OL Parameters':

https://tile.jawg.io/jawg-sunny/{z}/{x}/{y}.png?access-token=${accessToken}

where you need to fill in your access token.

— Reply to this email directly, view it on GitHub https://github.com/mastervanleeuwen/J-TrackGallery/issues/35#issuecomment-1404217490, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMUDBJ65SVZXRGZEUDHV53WUGIBTANCNFSM6AAAAAAS5NZA6M . You are receiving this because you authored the thread.Message ID: @.***>

-- Patrick Egloff email : @.*** Web page : http://www.egloff.eu

tk5ep commented 1 year ago

update !

I installed all files I could find on your Github, and it works now ! Does the package not contain all modules, plugin ?

Or was it a cache issue?

BTW, the modules date are wrong as does the screencopy show.

Thanks, Patrick [image: j!track_1.JPG] Anyway it works.

Le mer. 25 janv. 2023 à 22:01, Marco van Leeuwen @.***> a écrit :

Dear Patrick,

Thanks for the follow-up. I had a look at the page source for this track: https://www.egloff.eu/index.php?option=com_jtg&view=track&id=19&lang=en

I see that only one map layer is initialised:

jtgMap.addControl(new ol.control.MousePosition( {coordinateFormat: ol.coordinate.createStringXY(4), projection: 'EPSG:4326' } ));

jtgMap.addControl(new ol.control.ZoomSlider());

jtgAddMapLayer(0,'','','OSM Mapnik', true);

I think that only happens when only a single map layer is currently active (note that you can switch whether a map is active or not in the map settings for each map).

I have been adding various fixes and updates in the development version, so it is probably worth updating to the latest version: https://www.egloff.eu/index.php?option=com_jtg&view=track&id=19&lang=en

Concerning your other question: yes, I think it should be possible to use jawg maps. Looking at their documentation, here:

https://www.jawg.io/docs/integration/leaflet/simple-map

They use the openstreetmap format, so you can create a new map with this URL for the tile server in the field 'OL Parameters':

https://tile.jawg.io/jawg-sunny/{z}/{x}/{y}.png?access-token=${accessToken}

where you need to fill in your access token.

— Reply to this email directly, view it on GitHub https://github.com/mastervanleeuwen/J-TrackGallery/issues/35#issuecomment-1404217490, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMUDBJ65SVZXRGZEUDHV53WUGIBTANCNFSM6AAAAAAS5NZA6M . You are receiving this because you authored the thread.Message ID: @.***>

-- Patrick Egloff email : @.*** Web page : http://www.egloff.eu

mastervanleeuwen commented 1 year ago

Hi, can I close this issue, or is there something pending? I read quickly through the thread above, and I think everything is addressed, but hesitate to let me know if I overlooked something.

I made several additional changes and improvements, so you may want to try the latest release candidate:

https://github.com/mastervanleeuwen/J-TrackGallery/releases/tag/0.9.34-rc32

The complete list of releases is here: https://github.com/mastervanleeuwen/J-TrackGallery/releases

tk5ep commented 1 year ago

Hi Marco,

I have had no more problems since some releases. I will upgrade to the last one.

What is the best upgrade solution ? Is it better to upgrade the complete package ?

Thanks, Patrick

Le sam. 27 mai 2023 à 20:43, Marco van Leeuwen @.***> a écrit :

Hi, can I close this issue, or is there something pending? I read quickly through the thread above, and I think everything is addressed, but hesitate to let me know if I overlooked something.

I made several additional changes and improvements, so you may want to try the latest release candidate:

https://github.com/mastervanleeuwen/J-TrackGallery/releases/tag/0.9.34-rc32

The complete list of releases is here: https://github.com/mastervanleeuwen/J-TrackGallery/releases

— Reply to this email directly, view it on GitHub https://github.com/mastervanleeuwen/J-TrackGallery/issues/35#issuecomment-1565644890, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMUDBLC6ZHDCHERDZQQF43XIJDLZANCNFSM6AAAAAAS5NZA6M . You are receiving this because you authored the thread.Message ID: @.***>

-- Patrick Egloff email : @.*** Web page : http://www.egloff.eu