mastervanleeuwen / J-TrackGallery

GPS Track Gallery component for Joomla
https://mastervanleeuwen.github.io/J-TrackGallery/
6 stars 0 forks source link

Front end language overrides #46

Closed noelada closed 1 year ago

noelada commented 1 year ago

Hi Marco, In the back end TRANSLATIONS, I added a change to Terrain: ; These are additional translation strings added by users ; Used in Front-end AND Back-end

COM_JTG_CAT_CAR_44="Car 4*4" COM_JTG_TERRAIN="Locality"

This works in the back end, but the front end is still showing "Terrain" from en-GB.com_jtg_common in ROOT/Language/en-GB

Also the new feature to disable difficulty does not work for me (I selected No from Use dropdown in Configuration/Difficulty Level). Disable Category works fine. Regards, Noel.

mastervanleeuwen commented 1 year ago

Hi Noel,

Thanks for the reports.

The issue with the language overrides was due to a typo in the code. This is fixed in this release:

https://github.com/mastervanleeuwen/J-TrackGallery/releases/tag/0.9.34-rc27

Concerning the difficulty setting: this was not yet applied in the plugin, I have now updated the plugin to also respect this setting (as well as the 'use category' setting). Note that you can still set the difficulty when uploading the track. I could also remove it there, but the database still has the field, so I initially thought it would better to keep it accessible.

Best regards, Marco.

noelada commented 1 year ago

Thanks Marco,

Another problem I noticed is that the delete track does not work from front end. It works fine from back end.

Regards,

Noel.

From: Marco van Leeuwen @.> Sent: Tuesday, January 31, 2023 8:18 AM To: mastervanleeuwen/J-TrackGallery @.> Cc: noelada @.>; Author @.> Subject: Re: [mastervanleeuwen/J-TrackGallery] Front end language overrides (Issue #46)

Hi Noel,

Thanks for the reports.

The issue with the language overrides was due to a typo in the code. This is fixed in this release:

https://github.com/mastervanleeuwen/J-TrackGallery/releases/tag/0.9.34-rc27

Concerning the difficulty setting: this was not yet applied in the plugin, I have now updated the plugin to also respect this setting (as well as the 'use category' setting). Note that you can still set the difficulty when uploading the track. I could also remove it there, but the database still has the field, so I initially thought it would better to keep it accessible.

Best regards, Marco.

— Reply to this email directly, view it on GitHub https://github.com/mastervanleeuwen/J-TrackGallery/issues/46#issuecomment-1409353546 , or unsubscribe https://github.com/notifications/unsubscribe-auth/A47X3T46G67UT3WARX6GE4TWVAVYPANCNFSM6AAAAAAUKQT2UI . You are receiving this because you authored the thread.Message ID: @.***>

mastervanleeuwen commented 1 year ago

Dear Noel,

Thanks for the report; this was a side-effect of the changes to the router that I made. I implemented a fix and released a new version: https://github.com/mastervanleeuwen/J-TrackGallery/releases/tag/0.9.34-rc28

Best regards, Marco.

noelada commented 1 year ago

Thank Marco,

Delete now works thank you.

Regards,

Noel.

From: Marco van Leeuwen @.> Sent: Wednesday, February 1, 2023 8:48 AM To: mastervanleeuwen/J-TrackGallery @.> Cc: noelada @.>; Author @.> Subject: Re: [mastervanleeuwen/J-TrackGallery] Front end language overrides (Issue #46)

Dear Noel,

Thanks for the report; this was a side-effect of the changes to the router that I made. I implemented a fix and released a new version: https://github.com/mastervanleeuwen/J-TrackGallery/releases/tag/0.9.34-rc28

Best regards, Marco.

— Reply to this email directly, https://github.com/mastervanleeuwen/J-TrackGallery/issues/46#issuecomment-1411113083 view it on GitHub, or https://github.com/notifications/unsubscribe-auth/A47X3T4VZNJV6LSELULDSTLWVGB77ANCNFSM6AAAAAAUKQT2UI unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

noelada commented 1 year ago

Thanks Marco, We have it installed in our main site now and are getting excellent reports from users. Cheers, Noel.