mastervanleeuwen / J-TrackGallery

GPS Track Gallery component for Joomla
https://mastervanleeuwen.github.io/J-TrackGallery/
6 stars 0 forks source link

? bug in recent change to maphelper.php #62

Closed noelada closed 1 year ago

noelada commented 1 year ago

Hi Marco, After the latest update, I am getting errors from com_jtg/helpers/maphelper.php The error is that $row->icon_e and $row->icon_n do not exist. If I change icon to start it gets rid of the errors. The line numbers are 250 and 251 in maphelper. Best wishes, Noel.

mastervanleeuwen commented 1 year ago

Hi Noel,

Thanks for the report. This was due an incomplete commit. The new version here: https://github.com/mastervanleeuwen/J-TrackGallery/releases/tag/0.9.34-rc35 adds these fields to the data base, to allow drawing the track marker in a different position in the overview map for some specific use cases.

Best regards, Marco.

noelada commented 1 year ago

Hi Marco,

I am getting an installation error with com_jtg.zip in this release:

Warning

JInstaller: :Install: Error SQL You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'start_n, ADD icon_e FLOAT(20) NOT NULL DEFAULT start_e' at line 2

Regards,

Noel.

From: Marco van Leeuwen @.> Sent: Monday, July 17, 2023 11:37 PM To: mastervanleeuwen/J-TrackGallery @.> Cc: noelada @.>; Author @.> Subject: Re: [mastervanleeuwen/J-TrackGallery] ? bug in recent change to maphelper.php (Issue #62)

Hi Noel,

Thanks for the report. This was due an incomplete commit. The new version here: https://github.com/mastervanleeuwen/J-TrackGallery/releases/tag/0.9.34-rc35 adds these fields to the data base, to allow drawing the track marker in a different position in the overview map for some specific use cases.

Best regards, Marco.

— Reply to this email directly, view it on GitHub https://github.com/mastervanleeuwen/J-TrackGallery/issues/62#issuecomment-1638162210 , or unsubscribe https://github.com/notifications/unsubscribe-auth/A47X3T7ABRS3XINB5KRBW6DXQU5YLANCNFSM6AAAAAA2MPK52I . You are receiving this because you authored the thread.Message ID: @.***>

noelada commented 1 year ago

Hi Marco,

I think the installation error was caused by the localhost environment I was using. I tried installing on our test server and it was successful. Please ignore my previous email.

Regards,

Noel.

From: Marco van Leeuwen @.> Sent: Monday, July 17, 2023 11:37 PM To: mastervanleeuwen/J-TrackGallery @.> Cc: noelada @.>; Author @.> Subject: Re: [mastervanleeuwen/J-TrackGallery] ? bug in recent change to maphelper.php (Issue #62)

Hi Noel,

Thanks for the report. This was due an incomplete commit. The new version here: https://github.com/mastervanleeuwen/J-TrackGallery/releases/tag/0.9.34-rc35 adds these fields to the data base, to allow drawing the track marker in a different position in the overview map for some specific use cases.

Best regards, Marco.

— Reply to this email directly, view it on GitHub https://github.com/mastervanleeuwen/J-TrackGallery/issues/62#issuecomment-1638162210 , or unsubscribe https://github.com/notifications/unsubscribe-auth/A47X3T7ABRS3XINB5KRBW6DXQU5YLANCNFSM6AAAAAA2MPK52I . You are receiving this because you authored the thread.Message ID: @.***>