search

masterzen / mysql-snmp

Net-SNMP perl agent for monitoring MySQL servers
http://www.masterzen.fr/software-contributions/mysql-snmp-monitor-mysql-with-snmp/
GNU General Public License v2.0
67 stars 33 forks source link

Support for mysql 5.6 #23

Closed zageyiff closed 11 years ago

zageyiff commented 11 years ago

I have modified the mysql-snmp in order to support mysql 5.6 I have forked and commit the changes, hope it helps!!

Regards

masterzen commented 11 years ago

Thank you very much for your contribution!

I've a couple of comments (inlined in the patch).

masterzen commented 11 years ago

So if you could split the patch in two and extract the bits not related to mysql 5.6, and fix the indentations, I'd be more than happy to merge your contributions.

Thank you!

zageyiff commented 11 years ago

I'll fix the indentations and do a new commit. Everything is related to mysql 5.6 so it will be just one commit

masterzen commented 11 years ago

OK, thank you for your explanations. I'll try to merge the revised patch this week.

masterzen commented 11 years ago

hmm, did you deliberately closed this PR? I'm going to reopen so that I don't forgot to merge it later in the week :)

zageyiff commented 11 years ago

Yes, I closed it. I messed with the commits and lost the history. So I did a new pull request here https://github.com/masterzen/mysql-snmp/pull/24

I'll be closing this one again :)