Return 'not_found' status when there no matching upload

masterzen / nginx-upload-progress-module

Nginx module implementing an upload progress system, that monitors RFC1867 POST uploads as they are transmitted to upstream servers.

http://wiki.codemongers.com/NginxHttpUploadProgressModule

Other

432 stars 101 forks source link

Return 'not_found' status when there no matching upload #26

Closed seletskiy closed 12 years ago

seletskiy commented 12 years ago

Why starting status returns for each upload ID than is not currently handled by module?

I think it is better to return not_found status for every upload that is not tracked by module.

Patch: seletskiy@1abda61852704be9f8fcd47c2bd302fe1b760941

masterzen commented 12 years ago

Actually this isn't a good idea. It can happen due to scheduling issues in the browser that a browser issue a probe slightly before the upload gets accepted, and the X-Progress-ID registered. So when returning 'starting', we ensure the client displays that an upload is in progress.

seletskiy commented 12 years ago

Hmmm, I did not think about that case, and, yeah, it makes sense. So, I close issue.