search

masterzen / nginx-upload-progress-module

Nginx module implementing an upload progress system, that monitors RFC1867 POST uploads as they are transmitted to upstream servers.
http://wiki.codemongers.com/NginxHttpUploadProgressModule
Other
432 stars 101 forks source link

Dynamic module support #46

Closed ctrochalakis closed 8 years ago

ctrochalakis commented 8 years ago

Hello,

Is it possible to add dynamic module support for nginx-upload-progress? The module is part of nginx-extras in debian/ubuntu and we are in the process of splitting the modules in separate packages.

Thank you,

masterzen commented 8 years ago

@ctrochalakis,

I have no idea what I need to do on a code level (would you have any pointers?), but I'll see if I can work on this feature this week.

masterzen commented 8 years ago

OK, I found this: https://www.nginx.com/resources/wiki/extending/converting/ which might be of great help.

I have no idea if the module will still work when dynamically loaded since it uses some Nginx internals that are probably not public API.

ctrochalakis commented 8 years ago

Hello, @masterzen and thank you for the quick reply.

Apparently I missed that this was merged in #43 but is not released yet. So, if the build behaves correctly it'd be great if you could release it as 0.9.1.

masterzen commented 8 years ago

I completely forgot it was merged :) I will do a bit of testing, and release a new version.

ctrochalakis commented 8 years ago

Thank you!

masterzen commented 8 years ago

@ctrochalakis , I've just released version 0.9.2 after some testing (see the github releases for access to the tar.gz) I'm closing this issue, feel free to reopen if you have any questions or comments.