search

mastilver / dynamic-cdn-webpack-plugin

Get your dependencies from a cdn rather than bundling them in your app
MIT License
343 stars 37 forks source link

Minor grammar fix in logging message #37

Closed davidjb closed 6 years ago

mastilver commented 6 years ago

Hi @davidjb

Would you mind updating the tests: https://github.com/mastilver/dynamic-cdn-webpack-plugin/blob/master/test/core.js#L331

codecov-io commented 6 years ago

Codecov Report

Merging #37 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #37   +/-   ##
=======================================
  Coverage   98.57%   98.57%           
=======================================
  Files           2        2           
  Lines          70       70           
=======================================
  Hits           69       69           
  Misses          1        1
Impacted Files Coverage Δ
src/index.js 98.48% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aa57927...867bbc3. Read the comment docs.

davidjb commented 6 years ago

Updated and tests pass.

mastilver commented 6 years ago

Thank you :)