mastilver / dynamic-cdn-webpack-plugin

Get your dependencies from a cdn rather than bundling them in your app

MIT License

343 stars 37 forks source link

Removes babel-plugin-transform-runtime #59

Closed NReilingh closed 5 years ago

NReilingh commented 5 years ago

This plugin requires the inclusion of babel-runtime as a production dependency, which was removed in a previous commit. Fixes #57.

NReilingh commented 5 years ago

Hmm, this fails for Node 6, (but not Node 8). Must be using some ES feature unsupported by Node 6. So if we actually want to resolve #57, whatever that is will need to be refactored, or babel-runtime will need to be added back.

OR since Node 6 LTS is EOL at the end of the month, support could be dropped then instead.

aulisius commented 5 years ago

Hey,

Thanks for the PR! Been a bit busy so couldn't get around to debugging it myself. This is good. I agree with your point about dropping support for Node 6 since it's reaching EOL soon.

I just merged #60 which drops Node 6 support. Once you rebase your branch with master, this PR is good to go.

Again, thanks for the PR!

codecov-io commented 5 years ago

Codecov Report

Merging #59 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #59   +/-   ##
======================================
  Coverage    98.8%   98.8%           
======================================
  Files           2       2           
  Lines          84      84           
======================================
  Hits           83      83           
  Misses          1       1

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ef234c5...9f1bc2c. Read the comment docs.

aulisius commented 5 years ago

Pinging @mastilver so that we can publish a new release.