search

mastilver / module-to-cdn

MIT License
45 stars 32 forks source link

fix: update the rules for react-router and react-router-dom >= 6.0.0 #33

Closed Mirochiu closed 1 year ago

Mirochiu commented 1 year ago

Hi all,

In this PR, I update the rules for react-router and react-router-dom >= 6.0.0.

Based on the rules defined in modules.json, CDN replied the files not found for react-router and react-router-dom. I try to fetch the files on CDN for all versions programmatically. The shorten result is shown below.

fetch => done https://unpkg.com/react-router@5.3.3/umd/react-router.min.js fetch => done https://unpkg.com/react-router@5.3.4/umd/react-router.min.js fetch => error https://unpkg.com/react-router@6.0.0-alpha.0/umd/react-router.min.js fetch => error https://unpkg.com/react-router@6.0.0-alpha.1/umd/react-router.min.js ... fetch => error https://unpkg.com/react-router@6.4.2/umd/react-router.min.js fetch => error https://unpkg.com/react-router@6.4.3-pre.0/umd/react-router.min.js fetch => error https://unpkg.com/react-router@6.4.3-pre.1/umd/react-router.min.js

The breaking change for react-router and react-router-dom both are above the 6.0.0. Therefore, I visit the CDN website and update the rules manually.

jmfrancois commented 1 year ago

The repository is not maintained. We maintain a fork under @talend/module-to-cdn if you want to

Mirochiu commented 1 year ago

Okay, i will try to migrate that