mastodon-dart / mastodon-api

This library provides the easiest and powerful Dart/Flutter library for Mastodon API 🎯
http://pub.dev/packages/mastodon_api
BSD 3-Clause "New" or "Revised" License
64 stars 13 forks source link

fix: Provide client scopes as a space delimited string instead of a json list #79

Closed Elleo closed 1 year ago

Elleo commented 1 year ago

1. Description

The currently existing behaviour sends scopes as a json encoded list (e.g. ["read", "write", "follow"]), however, Mastodon expects a space-separated string ("read write follow"). This PR corrects that behaviour so that apps are assigned the correct scopes by the Mastodon server.

1.1. Checklist

1.2. Breaking Change

1.3. Related Issues

Fixes #78

codecov-commenter commented 1 year ago

Codecov Report

Merging #79 (8e80bff) into main (53eca1b) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #79   +/-   ##
=======================================
  Coverage   69.35%   69.35%           
=======================================
  Files          85       85           
  Lines         832      832           
=======================================
  Hits          577      577           
  Misses        255      255           
Impacted Files Coverage Δ
lib/src/service/v1/apps/apps_v1_service.dart 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

myConsciousness commented 1 year ago

@Elleo , Thanks for your contribution! :)

myConsciousness commented 1 year ago

bors merge

myConsciousness commented 1 year ago

@all-contributors please add @Elleo for code, bug, test

allcontributors[bot] commented 1 year ago

@myConsciousness

I've put up a pull request to add @Elleo! :tada:

bors[bot] commented 1 year ago

Build succeeded: