search

mastodon-sc / mastodon

Mastodon – a large-scale tracking and track-editing framework for large, multi-view images.
BSD 2-Clause "Simplified" License
69 stars 20 forks source link

Grapher does not print values #212

Open stefanhahmann opened 2 years ago

stefanhahmann commented 2 years ago

Bug description

The grapher view does not plot values that are actually existing in the table view.

Steps to reproduce the bug

  1. Start Fiji
  2. Start Plugin Mastodon
  3. open Mastodon project grapher-bug.mastodon: https://cloudstore.zih.tu-dresden.de/index.php/s/XgbnqRDgb9jLXLb
  4. Confirm dialog image data not accessible
  5. Open grapher
  6. Select "Spot position - X" for X axis
  7. Select "Spot position - Y" for Y axis
  8. Select "From context" - "full graph"
  9. Press "Plot"
  10. Check the result in the grapher view. No points are plotted in the diagram, even though the plot window is updated. It zooms to a location without data points. Giving the user the impression that there is no data available.

Additional information:

The way to zoom out is to first click on the plot and afterwards use Shift+Crtl+Scroll or Z + Z to zoom out. After successfully zooming out once, everything works nicely.

GIF 22 11 2022 12-33-23

Version:

ImageJ 1.53t Mastodon: 1.0.0-beta-26 Windows: 10 + Ubuntu 20.04 LTS

Tasks:

tinevez commented 2 years ago

I can get it to work:

Screenshot 2022-11-22 at 15 40 13

But I had to unzoom first, as the grapher window was showing the bottom left part of the plot, where there is no data point.

stefanhahmann commented 2 years ago

I agree. It also works for me now. I actually even tried zooming, but wasn't aware of the shortcuts (particularly ctrl + shift + scroll wheel to zoom on both axes is unusual to me). Now I am also aware of the 'Z'-button functionality (had problems with this, since the machine that I am currently using is bit to slow for the dataset I wanted to analyse).

Nevertheless, I would like to suggest a usability enhancement:

Additionally, https://mastodon.readthedocs.io/en/latest/docs/partB/table_bdv_navigation_keys.html would need a similar section for the Grapher as well. Without @maarzt telling me, I would not have found found how to scroll on both axes in the Grapher viewer (and similarly a newbe user perhaps would also not find out on its own).

maarzt commented 2 years ago

@stefanhahmann wrote:

  • When I set "From context" and "full graph" and press "Plot", the Grapher window makes an animation of the axes. This gives the user the impression that the Grapher window tries to zoom to the full extent of the data. I suggest to omit this behaviour, since it is a bit irritating. At least for me, it was not clear what happened during the animated adjustment of the axes.

I think there is indeed some bug. After opening a new grapher window, selecting "Spot - X", "Spot - Y", "From context: full graph" and clicking "Plot", the plot window is updated. But it zooms to a location without data points. Giving the impression that there is no data available. The way to zoom out is to first click on the plot and afterwards use Shift+Crtl+Scroll or Z + Z to zoom out. I myself couldn't find how to zoom out, despite knowing the short cuts. So I too got the impression, that the grapher window is buggy. After I successfully zoomed out once, everything worked really nicely. So there seems to be a problem only with the initial state after opening a new grapher window.

Let's try to fix the initial zoom state of the grapher window. And also add a "Fit axes" button for convenience.