Color TrackScheme Hierarchy according to the time point (Issue 213)

mastodon-sc / mastodon

Mastodon – a large-scale tracking and track-editing framework for large, multi-view images.

BSD 2-Clause "Simplified" License

66 stars 20 forks source link

Color TrackScheme Hierarchy according to the time point (Issue 213) #215

Closed stefanhahmann closed 1 year ago

stefanhahmann commented 1 year ago

See PR #231 instead ~~Closes #213~~

stefanhahmann commented 1 year ago

Visualisation of current implementation:

issue213

grafik

stefanhahmann commented 1 year ago

Feedback from users:

both daughter cells should get black at the same time (this was not done initially, since it was decided that the branch is only then shown in black color, if it completely contained)
could we have the same feature also for branch view? → actually not so much needed, since there is already the horizontal line
would be nice to have the sum of the spots of the current timepoint somewhere visible in the trackscheme (e.g. in the bottom bar of the trackscheme view)

isse213

maarzt commented 1 year ago

Hi @stefanhahmann,

I finished the review. Could you try to implement the suggested FadedModel approach. I noticed also that the isAfterTimepoint() methods are currently unused. And that the spots are faded not exactly at the correct timepoint. I thought you fixed that already!? There might be a commit in your local repo that you forgot to push?

stefanhahmann commented 1 year ago

Closed an replaced by: https://github.com/mastodon-sc/mastodon/pull/231

stefanhahmann commented 1 year ago

Hi @stefanhahmann,

I finished the review. Could you try to implement the suggested FadedModel approach. I noticed also that the isAfterTimepoint() methods are currently unused. And that the spots are faded not exactly at the correct timepoint. I thought you fixed that already!? There might be a commit in your local repo that you forgot to push?

I implemented the suggested FadedModel. It is quite similar to the already existing SelectionModel. The isAfterTimepoint() / isBeforeTimepoint methods are not needed anymore and are therefore deleted.