search

mastodon / chart

Helm chart for Mastodon deployment in Kubernetes
GNU Affero General Public License v3.0
154 stars 89 forks source link

make probes on streaming and web deployments user configurable #10

Open jstewart612 opened 1 year ago

jstewart612 commented 1 year ago

Implements https://github.com/mastodon/chart/issues/9

jstewart612 commented 1 year ago

@SISheogorath all requested changes made, please verify/review.

jstewart612 commented 1 year ago

@SISheogorath @renchap rebased, please review

timetinytim commented 3 months ago

(Sorry for the huge delay in getting around to this)

Generally I think this is a great idea. The values look good to me, I just want to ping @renchap to take a look as well before I approve.

timetinytim commented 3 months ago

So we had a discussion internally about this.

Generally it's a good idea to allow the customization of healthcheck endpoints. But there are two concerns with this particular implementation:

To clarify the second point, consider the possibility that we change the healthcheck endpoint in a future version. The onus to update the values file is then on everyone who uses the chart, and will lead to things breaking if people don't know they have to update it.

I would instead suggest that the probes be constructed out of whatever values the user chooses to define, and fills in the rest of the probes' parameters with default values.

Hopefully that makes sense!