search

mastodon / chart

Helm chart for Mastodon deployment in Kubernetes
GNU Affero General Public License v3.0
154 stars 89 forks source link

Helm Deployment - DB migrate job should run on post-upgrade #26

Open feli-suco opened 3 years ago

feli-suco commented 3 years ago

Helm Deployment - DB migrate job should run on post-upgrade, instead on pre-upgrade

https://github.com/tootsuite/mastodon/blob/c3786b29b7730b8c858320599508a20b11884108/chart/templates/job-db-migrate.yaml#L8

Looking at the upgrade notes: https://github.com/tootsuite/mastodon/releases/tag/v3.3.0

image

I guess the db migrate job should run after the new code is running.

If you are upgrading to a new mastodon version, with the current configuration, the db-migrate job is running after the new image is pulled.

SISheogorath commented 1 year ago

I just added this commit to my chart in order to handle things according to the upstream docs for zero downtime upgrades: https://git.shivering-isles.com/shivering-isles/infrastructure-gitops/-/commit/8f9931ec09403a8964fd82993e3f3d8033d19dec

dunn commented 1 year ago

looks nice, a PR would be very welcome!

angdraug commented 1 year ago

PR #37 tries to address both this and #18.