Fix container create error on unauthenticated SMTP

mastodon / chart

Helm chart for Mastodon deployment in Kubernetes

GNU Affero General Public License v3.0

158 stars 92 forks source link

Fix container create error on unauthenticated SMTP #49

Closed ananace closed 5 months ago

ananace commented 1 year ago

If you're using an internal SMTP server which doesn't use authentication for services, then the helm chart deploys an unusable sidekiq container;

$ kubectl --namespace mastodon get pods
...
mastodon-sidekiq-all-queues-58c6b4948f-fktj6   0/1     CreateContainerConfigError   0                24s
$ kubectl --namespace get events | grep sidekiq
...
32s       Warning   Failed                   pod/mastodon-sidekiq-all-queues-58c6b4948f-fktj6    Error: couldn't find key password in Secret mastodon/mastodon-smtp

jasonadamyoung commented 8 months ago

Can a maintainer please merge this?

This one is a simple, low-impact change for anyone with a password, and it's definitely necessary for those without it.

I've been running with this since at least last year when @ananace submitted the PR.

Thanks!

jasonadamyoung commented 8 months ago

This definitely speaks to the maintenance assistance desire in https://github.com/mastodon/chart/issues/46

timetinytim commented 5 months ago

Sorry for the delay! We're finally going through the chart. Getting it merged now.

jasonadamyoung commented 5 months ago

Great, thanks for picking this up @timetinytim!

I also just circled back and read https://github.com/mastodon/chart/issues/129 as well, that's all exciting. Thanks for your work and communication, Tim!