search

mastodon / chart

Helm chart for Mastodon deployment in Kubernetes
GNU Affero General Public License v3.0
152 stars 90 forks source link

Double reference to checksum/config-secrets #66

Closed ryphon closed 1 year ago

ryphon commented 1 year ago

https://github.com/mastodon/chart/blob/4b6fd9f7e6273cb2708e5f8e16b87b1d07114eb8/templates/deployment-sidekiq.yaml#L38

vs

https://github.com/mastodon/chart/blob/9806bbc8b1bb270e0f1d5cc951c5ce4f1077802d/templates/_helpers.tpl#L61

Not sure how you'll want this resolved. You define the config-secrets annotation in both the helpers and that specific deployment. Unfortunately that means the values are doubled up, and k8s does not like it when that happens very much. Maybe remove the helpers, and let the sidekiq deploy do the annotation without the helper function?

Happy to do a PR and test, but don't know what would be preferred in this case.

ryphon commented 1 year ago

The link didn't give a lot of context, but the first link, one line up has https://github.com/mastodon/chart/blob/4b6fd9f7e6273cb2708e5f8e16b87b1d07114eb8/templates/deployment-sidekiq.yaml#L37

ryphon commented 1 year ago

dupe, closed in favor of #48