mastodon / chart

Helm chart for Mastodon deployment in Kubernetes
GNU Affero General Public License v3.0
152 stars 90 forks source link

Add s3.mastodon.multipart_threshold config option #67

Closed hinricht closed 2 months ago

hinricht commented 1 year ago

When uploading data to S3, if the number of bytes to send exceedes multipart_threshold then a multi part session is automatically started and the data is sent up in chunks.

hinricht commented 1 year ago

Please don't merge yet, I'll need to test it with different values first.

hinricht commented 1 year ago

Ok, tested, works well. Can get reviewed/merged.

jessebot commented 1 year ago

I think you may also need to bump the chart version in Chart.yaml by just a patch version.

hinricht commented 1 year ago

I think you may also need to bump the chart version in Chart.yaml by just a patch version.

I thought the same in https://github.com/mastodon/chart/pull/45, but @renchap explicitly asks for not bumping the chart versions for PRs: https://github.com/mastodon/chart/pull/5#issuecomment-1440044699

@renchap Does this still apply ? And what's the state of the helm chart in general, last change in Chart.yaml is already 7 month ago, it would be nice to merge some of the pending PRs and release a new chart version.

jessebot commented 1 year ago

@hinricht oh, didn't realize that, sorry for misleading you! 🙏

hinricht commented 4 months ago

@renchap @timetinytim Any chance to get this merged ?