mastodon / mastodon-android

Official Android app for Mastodon
https://app.joinmastodon.org/android
GNU General Public License v3.0
1.63k stars 251 forks source link

QR code scanning does not work on MicroG / Degoogled devices #825

Open LucasGGamerM opened 2 months ago

LucasGGamerM commented 2 months ago

I took a look the code responsible by doing this, and it seems like we are using google's mlkit to do the work for us. Could that be the reason as for why it doesn't work on a degoogled phone?

And does that mean that we also indirectly depend on google for the qr code scanning capabilities?

grishka commented 2 months ago

It is the reason it doesn't work with MicroG.

The reason I used Google's QR code scanner is that it doesn't require the camera permission. Otherwise, the ZXing library already included in app for generating QR codes can also scan them, but this is not implemented, at least for now.

LucasGGamerM commented 2 months ago

Moving to an in app solution would be nice, specially considering gms is a privacy nightmare. Not needing the camera permission is something we should at least consider giving up for the sake of better compatibility and more privacy.

Forgive the previous rant, as depending on GMS for anything other than push notifications is not a good idea (and not even that at times).