mastodon / mastodon-ios

Official iOS app for Mastodon
https://app.joinmastodon.org/ios
GNU General Public License v3.0
2.09k stars 269 forks source link

[BUG] Always expand posts marked with content warnings not working #511

Open dgiffin opened 2 years ago

dgiffin commented 2 years ago

Is there an existing issue for this?

Current Behavior

In Settings I set both Media Display: Always show media and Always expand posts marked with content warnings to ON, then I SAVE CHANGES, then cancel out of settings.

Content with warnings still ask me to Tap to reveal.

Expected Behavior

Content with warnings should be displayed.

Steps To Reproduce

No response

Environment

- Device: iPhone and iPad 
- OS: 16
- Version:
- Build:

Anything else?

The correct behaviour is taken in the Toot! app

Yonodactyl commented 2 years ago

Not a core contributor, take this with a grain of salt:

I don't believe the app sets these properties, but rather the web component of Mastodon does. Mastodon might not have any inclination of what's happening when you're pulling levers on the other side of the fence.

I think a possible solution would be to reinitialize whatever coordinator is controlling these options (and that's even if they are available on the core app). I hope to familiarize myself with the codebase to help, but I just now have come across it!

Hope we can find a solution to this issue together!

j-f1 commented 2 years ago

Agreed, @Yonodactyl. I looked through the code and the app does not currently appear to fetch any settings from the Mastodon API. So only the in-app settings are respected (although it would be nice if the account settings were respected too)

dgiffin commented 2 years ago

But I have set this in the app, obviously I am missing something

j-f1 commented 2 years ago

This issue tracker is for the official Mastodon app, not the third-party Toot! app

davidcelis commented 2 years ago

@dgiffin the app doesn't have a setting for this at all, from what i can tell… are you by any chance going into the app settings and then clicking the link that opens your account settings in the in-app browser? because that'll just allow you to view or modify your settings/preferences on the web, and you're right that many of them (including the one referenced in this issue) ultimately don't have any effect in the app.

i came to report that the app doesn't respect the "Always expand posts marked with content warnings" setting too, but it looks like there are other settings not being synced between my web account and the app or respected from the app. in general it would be nice for the app to pull my settings via the web API and actually apply them

AnVaimpir commented 2 years ago

Currently you have to use the iOS PWA or MetaText if you want to have the CW auto expand. It'd be great to have the official iOS app honoring this account setting like the other apps.

redpola commented 2 years ago

This issue seriously hampers my use of Mastodon iOS when, instead of casually scrolling through posts I have to tap on almost every one just to see the content.

It’s a major content speed issue compared to Twitter.

jakebeamish commented 1 year ago

This is probably a totally different issue, just commenting here as it could be related.

Unless they’re clicked on, posts with content warnings should only use as much vertical space as is needed to display the warning. If they are tapped on, they should expand to show the full post.

Currently, a post with a content warning (and only the warning is displayed) takes up as much vertical space as the unhidden view of the post.