mastodon / mastodon

Your self-hosted, globally interconnected microblogging community
https://joinmastodon.org
GNU Affero General Public License v3.0
47.08k stars 6.97k forks source link

Move block imports to a separate tool #20471

Closed kaniini closed 10 months ago

kaniini commented 1 year ago

Pitch

I just accidentally imported all of my following list from Twitter (generated with Fedifinder) as blocks by accident, because my mouse pointer was sitting over the dropdown list and scrolled it (due to having two fingers on the trackpad by accident) rather than moving down to the import button.

It seems strange to me to have constructive outcomes (creating new follow relationships and bookmarks) on the same screen as destructive outcomes (creating new block relationships).

These should be two different screens, or at the very least, it should prompt for verification before proceeding with a destructive operation, e.g. a modal which says "you are about to import 400 block relationships, are you sure you want to continue?"

Motivation

People who don't want to accidentally follow their blocking list, or block their following list. I suspect this type of mistake happens frequently.

stramargio commented 1 year ago

Same happened here, tbh.

rscmbbng commented 1 year ago

Not the same issue, but an outcome of the lack of feedback on list imports: https://github.com/mastodon/mastodon/issues/19770

ClearlyClaire commented 1 year ago

FYI, I'm starting to rewrite imports and overhaul both the code and the UI. I do not intend to move importing blocks to another tool, but I intend a few UX changes around that:

image

rscmbbng commented 1 year ago

Longer term it would be important to do a complete design overhaul of blocklist managment, though. There is quite some scientific literature, in addition to many anecdotes, on how blocklists are either not effective enough or easy to abuse. Designing an interface that would allow one to inspect a blocklist before it is applied could help mitigate some of that at least. I'd be happy to collaborate on that if there is the desire to look in to it.

ClearlyClaire commented 1 year ago

Agreed, but the main purpose is to import your own blocks from a previous account, or a different account you maintain.

jsandburg commented 1 year ago

There is also the problem where if you import your following list as blocks, you can't undo it by simply re-uploading your blocks list and overwriting. I'm not sure why that's an option when it doesn't work for blocks. In reality, you cannot unblock anyone unless you do it manually by going into your profile.

ClearlyClaire commented 1 year ago

There is also the problem where if you import your following list as blocks, you can't undo it by simply re-uploading your blocks list and overwriting. I'm not sure why that's an option when it doesn't work for blocks. In reality, you cannot unblock anyone unless you do it manually by going into your profile.

Hm, that sounds like a bug. I'll try to investigate later. Which version of Mastodon are you using?

jsandburg commented 1 year ago

This happened on v4.1.6