search

mastodon / mastodon

Your self-hosted, globally interconnected microblogging community
https://joinmastodon.org
GNU Affero General Public License v3.0
46.51k stars 6.85k forks source link

Re-introduce the spinning animation for the boost button #28784

Open ShadowJonathan opened 6 months ago

ShadowJonathan commented 6 months ago

Pitch

Before the latest icon change (to material design), the boost button had its own animation that "spun" the two arrows along its path, not dissimilar to the spinning favourite button.

Could that be re-introduced?

Motivation

It served as a pleasant feedback to actually clicking something, in absence of haptics on desktop, and its absence is very much noted in the last few commits/updates.

ShadowJonathan commented 6 months ago

(Originally filed at https://github.com/glitch-soc/mastodon/issues/2576)

ChasBelov commented 2 months ago

If the user has prefers-reduced-motion set to reduce, don't do the animation.

omentic commented 2 months ago

Oh, I haven't actually had the chance to set up a build environment and test it, but I'm fairly confident this patch should work: https://github.com/ralsei/types.pl/commit/a597db574657a581e7df0373c2a82d51f093a351

@ShadowJonathan if interested

ShadowJonathan commented 2 months ago

Sorry, that's not the correct spin animation. The older spin animation was a custom multi-frame animation that kept the general square shape of the boost icon, while "sliding" the arrows along it.

omentic commented 2 months ago

Oh, that's a bummer: so it'll have to be redone with the material icons swap, huh?

Hmm. I'll see if I can't dig it back up for reference.