search

mastodon / mastodon

Your self-hosted, globally interconnected microblogging community
https://joinmastodon.org
GNU Affero General Public License v3.0
47.08k stars 6.97k forks source link

No notifications for new followers when filtered #32441

Open joenepraat opened 3 weeks ago

joenepraat commented 3 weeks ago

Steps to reproduce the problem

  1. Set (for simplicity) everything below Manage notifications to Filter:

afbeelding

  1. Make sure the test users (A and B) don't follow each-other.
  2. Follow user B with user A.
  3. I expect a Filtered box at the top of the notifications column to appear, but it doesn't. Also if you wait or refresh the browser-tab.

I noticed this bug after I saw a favorite on my reply, but not as filtered in my notification column. I checked everything, if this user was not e.g. limited. After I tested it like I explained above. Also note that I tested from both sites (todon.nl and mastodon.social) and only on todon.nl.

Expected behaviour

When set a notification type to filtered a Filtered notification box should appear when a users follows another user.

Actual behaviour

See step 1 to 4

Mastodon servers

todon.nl and mastodon.social

Mastodon version

v4.3.0

Browser name and version

Firefox 131.0

Operating system

Ubuntu Linux 24.04 LTS

Edits: See https://github.com/mastodon/mastodon/issues/32441#issuecomment-2411990308

joenepraat commented 3 weeks ago

@renchap @ClearlyClaire I think this is a major bug, that probably should be solved before the 4.3.1 release.

joenepraat commented 3 weeks ago

Or is this a feature? 👀

ClearlyClaire commented 3 weeks ago

This is awkward but intended. Notification filters still apply to boost/favs because those can still generate a lot of noise, but those filtered notifications do not create notification requests, because that would be a lot of noise as well, and highly confusing to users (a previous version of the implementation counted such notifications as pending filtered notifications, which created the impression that someone was spamming them with messages, while they just had favourited a bunch of those)

joenepraat commented 3 weeks ago

This is awkward but intended.

Thanks for the explanation. Maybe it would be an idea to explain that somewhere, because I at least was expecting notification requests for boosts/favs as well. BTW: I also didn't receive notifications about new followers. Is that also intentional? I can understand boost/favs, but not really new followers. I guess almost all people want to see who started following them, even when filtered. So I change this issue to only the new followers part.

ClearlyClaire commented 3 weeks ago

Hm, notifications for new followers being filtered seems like an oversight. I think it makes more sense to see follow notifications than them being filtered indeed.