search

mastrup / ourHtagEditor

H-tag property editor for Umbraco.
MIT License
7 stars 8 forks source link

Feature Request: P tag #14

Open BarryFogarty opened 2 years ago

BarryFogarty commented 2 years ago

It'd be great to have a P tag included in the list of allowed tags. I can try to submit a PR if you'd be interested?

mastrup commented 2 years ago

I can see the use case for the editor being able to set the text as a non-h-tag. I think the picker in the backoffice should illustrate that the editor is able to set a non-h-tag and then the rendering would be up to the developer. I am not sure about the look of the icon, but indicating that it would be a p-tag seems a bit limiting.

If this is implemented, the tag helper should also be extended, so a developer is able to set what a non-h-tag should be rendered in.

Let me know that you think - I would welcome a PR! 🚀

BarryFogarty commented 1 year ago

Just to note - I have hacked this in the Angular controllers to allow a P tag by just adding it to the array of allowed tags (defaultSizes)- it doesn't even require a change to the TagHelper to render a P tag. But as you say, for it to be a part of the package I don't know how to resolve the UI side of things if developers want to include other tags - ideally it wouldn't need to use an icon at all. But I don't really know how to accomplish this so I'll have to make do with my hack I think and leave this here for others to pick up. Thanks again for a great little package 👍