search

masukomi / private_comments

a tool for managing private comments on, but not in, your files
48 stars 2 forks source link

private_comments needs to support DELETE rest action #3

Closed masukomi closed 4 years ago

masukomi commented 4 years ago

we should be able to delete a comment by sending a DELETE request to /v1/comments endpoint.

params would be essentially the same as creating a comment only without the comment key. For example: 

{
  "project_name_hash": "7135459ae30c0d5180b623986c420bf20856461cb6b9b860986a22c7654ed755",
  "file_path_hash": "faf3e6fc36b8524dad3aa4a317e734623f0dfcf6934a659015827406ebfb0c87",
  "treeish": "777a58e942164e94964999bcc7cd20bbcda28fe55ac38be28e530f58ddad5ad8",
  "line_number": 4
}

If there is currently not comment on that treeish + line_number tuple it should just return success because the user's intent of there being no comment on that line in that version has been achieved (through no action).

masukomi commented 4 years ago

added in commit f1e82ce6686c1fe783d55723049ce17cfb6fb3aa