masumsoft / express-cassandra

Cassandra ORM/ODM/OGM for NodeJS with support for Apache Cassandra, ScyllaDB, Datastax Enterprise, Elassandra & JanusGraph.
http://express-cassandra.readthedocs.io
GNU Lesser General Public License v3.0
228 stars 67 forks source link

No error with `doBatch`, error with `doBatchAsync` #271

Closed aorlowskiddm closed 10 months ago

aorlowskiddm commented 10 months ago

I am trying to batch a delete & insert:

          const queriesToExecute = []
          queriesToExecute.push(event1.delete({return_query: true}))
          queriesToExecute.push(event2.save({ if_not_exist: true, return_query: true }))  
           models.doBatch(queriesToExecute, (err: any) => {
            if (err) {
              console.log("Error!")
            }
            console.log("No error.")
          })

With this, I am seeing no error. However, if I swap it into async:

          const queriesToExecute = []
          queriesToExecute.push(event1.delete({return_query: true}))
          queriesToExecute.push(event2.save({ if_not_exist: true, return_query: true }))  
          models.doBatchAsync(queriesToExecute)
          .then((err: any) => {
            if (err) {
              console.log("Error!")
            }
            console.log("No error.") 
          })

I am seeing an error. Am I doing something wrong?

aorlowskiddm commented 10 months ago

I found that the return on doBatchAsync isn't reflective of an error. The results persist.