mat1jaczyyy / lpp-performance-cfw

Performance-optimized Launchpad Pro Firmware modification
BSD 3-Clause "New" or "Revised" License
89 stars 26 forks source link

LPX support #45

Closed awesome-coder-d closed 3 years ago

awesome-coder-d commented 3 years ago

Hello mat1jaczyyy,

I think there should be a CFW for Launchpad X. I own one, so I think it would be helpful.

conc1erge commented 3 years ago

Not gonna speak for Mat here but:

Novation didn't release an open source version of the X's firmware, Only the Pro MK1. Without the full source of the X's firmware, a lot of reverse engineering has to be done and nobody has time for that.

RagnaLP commented 3 years ago

lpx fw isnt open source, so its either gonna be reverse engineered to shit or it isnt gonna exist, everything you need is on the stock firmware anyway

SanJacobs commented 3 years ago

Since I don't see any information about this in the readme, and this seems somewhat related, is this compatible with the Launchpad Pro MK3?

RagnaLP commented 3 years ago

no, each lp has different fw even if it performs similarly

awesome-coder-d commented 3 years ago

thanks for telling me conc1erge. I am typing this reply via email. LOL

On Wed, Mar 3, 2021 at 10:28 PM RagnaLP notifications@github.com wrote:

no, each lp has different fw even if it performs similarly

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mat1jaczyyy/lpp-performance-cfw/issues/45#issuecomment-790333851, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARKZ53EWNYKR3XYWRMK5FOTTB4SBBANCNFSM4YKV4XSA .

mat1jaczyyy commented 3 years ago

Interfacing with hardware is obviously different if you have different hardware units. Any naming scheme similarity can't mean the hardware is remotely similar, even if looks the same on the surface.

Novation released libraries for talking to the LP Pro hardware only, all other models don't have this. While we can manually figure out how to talk to the hardware by reversing stock firmwares, and this is something that's near impossible to do (but still technically can be done).

For now, I won't be touching this, but this might change in the future (and if it does, the old MK2 will go down first.)

SanJacobs commented 3 years ago

I'd suggest writing that this is only for the mark 1 in the readme. I doubt I'm the only person who has been confused by the use of just "Pro", since there are multiple Pro models.