matanbs / webm

Automatically exported from code.google.com/p/webm
0 stars 0 forks source link

bug in webm-tools webm_crypt.cc #881

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
In DecryptModule::DecryptData

line 344,
      const size_t offset = EncryptModule::kSignalByteSize + sizeof(iv);

iv is declared in line 331,
      const string iv(iv_data, EncryptModule::kIVSize);

Uses sizeof operator against std::string instances (looks like copy/paste 
error).

It produced clipped output when compiled with MS VS 2013.

I'd like to suggest replace all "sizeof(iv)" to EncryptModule::kIVSize. IV is 
fixed size after all.

Original issue reported on code.google.com by roh0...@gmail.com on 18 Nov 2014 at 8:58

GoogleCodeExporter commented 9 years ago

Original comment by renganat...@google.com on 20 Nov 2014 at 11:16

GoogleCodeExporter commented 9 years ago
https://gerrit.chromium.org/gerrit/#/c/73525/

Original comment by fgalli...@google.com on 16 Jan 2015 at 7:14

GoogleCodeExporter commented 9 years ago

Original comment by fgalli...@google.com on 4 Mar 2015 at 8:25