search

matanlurey / gba.dart-archived

A gameboy advanced emulator written in Dart
https://github.com/matanlurey/gba.dart
12 stars 4 forks source link

Use more constants in Arm7TdmiRegisters #22

Closed matanlurey closed 7 years ago

matanlurey commented 7 years ago

@kharland wrote in #21:

using int constants would be more clear here. Otherwise just using the sum should be fine:

   const _svcViewOffset = 24 * Uint32List.BYTES_PER_ELEMENT
   const _svcViewLength = 3 *  Uint32List.BYTES_PER_ELEMENT

Maybe wrapped in a class _RegisterPositions or something. or just 17, 25, 28, etc.