gtolle
commented
10 years ago Hi Matan,
I just checked out your movies app on Heroku. Basic functionality's all there, but I have a few suggestions:
- Your 'add a movie' link is just called 'movies', but 'add a movie' would be clearer
- Your movie title links to the 'edit' page, but it should link to the 'show' page instead. Then, put an 'edit' button on the show page.
- Your edit form also says 'Create Movie', and I know I didn't tell you a good way around that, but you could use an if statement in your view, and set a variable in your controller. Or, you could check against params[:action].
Also, in the future, I'd suggest using application.html.erb to put some common elements on each page, like a site title or navbar.
Gil
On Thu, Nov 21, 2013 at 6:04 PM, Matan-Paul Shetrit < notifications@github.com> wrote:
The app: http://pure-waters-7038.herokuapp.com/
@gtolle https://github.com/gtolle
@JustinDSN https://github.com/JustinDSN
— Reply to this email directly or view it on GitHubhttps://github.com/matanpaul/movies/issues/1 .
The app: http://pure-waters-7038.herokuapp.com/
@gtolle
@JustinDSN