Increment platform interface

matanshukry / flutter_google_places_sdk

Flutter plugin for google places native sdk

32 stars 68 forks source link

Increment platform interface #1

Closed mathrocco closed 3 years ago

mathrocco commented 3 years ago

What

Increment platform interface with the following implementation:

Autocomplete API:
- Add sessionToken: bool param
- Add origin: Location param
Place Details implementation with the following params:
- placeId
- fields: List<PlaceField>
- PlaceField with LAT_LNG option only for now

After merged and publish, there's another Pull Request on the line with the new interface implementation

matanshukry commented 3 years ago

@mathrocco Thanks for the PR!

I've added few mostly-"cosmetic" comments that I could quickly find by looking at the PR, but it looks good overall. One thing that's missing is a test to the test file. You can see the test for the findAutocompletePredictions to make something like that.

I'll take a closer look when I can.

matanshukry commented 3 years ago

I ended up doing a bigger change due to null safety, and inserted your changes manually with more.

Thank you for your PR!