search

matanshukry / flutter_google_places_sdk

Flutter plugin for google places native sdk
36 stars 74 forks source link

Macos support #28

Closed voicubabiciu closed 1 year ago

voicubabiciu commented 1 year ago

Added support for macOS platform and also implemented the fetchPlace function

Closes 26

krjw-eyev commented 1 year ago

This would be really helpful. What's the status if I may ask?

matanshukry commented 1 year ago

@voicubabiciu since the impl is the same as windows impl, they should be a single one rather than duplicated.

I did the work of extracting the windows package to another one ("http" now), and also changed the window to use it.

What should be done now then:

  1. Impl the fetchPlace into the ..._http library
  2. Create a macos package, much like the window one, that uses the http one.
  3. Add the macos to the default package impl
  4. Optional: upgrade window to use the new ..._http library after implementing the fetchPlace

Note that each point need to be a separate commit (hence separate PR).

@voicubabiciu let me know if you want to do it - otherwise I'll just implement it. And thanks for your contribution btw!

voicubabiciu commented 1 year ago

@matanshukry Hello, sorry but right now I don't have enough time to work on it. Feel free to implement it.

matanshukry commented 1 year ago

@voicubabiciu done, implemented.

I don't have personal mac to test this - but the implementation is pretty straightforward - so 🤞