matanshukry / flutter_google_places_sdk

Flutter plugin for google places native sdk
36 stars 74 forks source link

Updated gradle version #35

Closed sguptazeil closed 1 month ago

sguptazeil commented 1 year ago

@matanshukry I'm not able to integrate the library because I have latest gradle plugin integrated. Could you please review this PR.

matanshukry commented 1 year ago

I tried updating to the latest, but I can't get it work. Seems there are issues in the IDE as well about it - although I'm facing errors in the cli:

* What went wrong:
A problem occurred configuring project ':integration_test'.
> Could not create an instance of type com.android.build.api.variant.impl.LibraryVariantBuilderImpl.
   > Namespace not specified. Please specify a namespace in the module's build.gradle file like so:

     android {
         namespace 'com.example.namespace'
     }

     If the package attribute is specified in the source AndroidManifest.xml, it can be migrated automatically to the namespace value in the build.gradle file using the AGP Upgrade Assistant; please refer to https://developer.android.com/studio/build/agp-upgrade-assistant for more information.

I added the namespace attribute to all the android { parts, so this shouldn't happen. I'll try to take a look again at some other time.

Branch: https://github.com/matanshukry/flutter_google_places_sdk/tree/android-upgrade

a-k-o-r-e-d-e commented 1 year ago

@matanshukry I dont know if this might help

https://docs.flutter.dev/release/breaking-changes/android-java-gradle-migration-guide

matanshukry commented 1 month ago

Gradle has already been upgraded so no longer relevant