search

matanshukry / flutter_google_places_sdk

Flutter plugin for google places native sdk
36 stars 74 forks source link

[iOS] Allow to provide multiple type filters for autocomplete search #48

Closed TatsuUkraine closed 1 year ago

TatsuUkraine commented 1 year ago

Places SDK allows to provide of multiple type filters for autocomplete predictions. But current version of the package allows to provide only 1.

https://developers.google.com/maps/documentation/places/android-sdk/reference/com/google/android/libraries/places/api/net/FindAutocompletePredictionsRequest.Builder#public-abstract-findautocompletepredictionsrequest.builder-settypesfilter-liststring-typesfilter

Also, the current method setTypeFilter marked as deprecated

https://developers.google.com/maps/documentation/places/android-sdk/reference/com/google/android/libraries/places/api/net/FindAutocompletePredictionsRequest.Builder#public-abstract-findautocompletepredictionsrequest.builder-settypefilter-typefilter-typefilter

TatsuUkraine commented 1 year ago

is this package still maintained at all?

matanshukry commented 1 year ago

Done and published almost all platforms - iOS is the only one missing. Leaving this open and tagging as iOS.

TatsuUkraine commented 1 year ago

Nice! Thank you

esuljic commented 1 year ago

I made a #57, seems like at this last release, the first is not working as well on iOS. It shows all of the results.

ctostech commented 1 year ago

The issue is still happening on iOS, any update?

matanshukry commented 1 year ago

I don't have a mac so I can't work on the iOS fix. That is why everything else is working except that.

Any PR is welcome though in the meantime, and I'll try to find some solution through pc in the meantime.

maxbritto commented 1 year ago

I've checked and in order to make this happen, we need to use the GooglePlaces swift sdk version 7.2.0 at least, which requires iOS 13 minimum. Hence, we have to raise this library iOS minimum deployment target from iOS 11 to iOS 13. As of this writing, iOS 13 and above represents 96,8% of the devices according to https://iosref.com/ios-usage I have the code ready @matanshukry, I let you decide what we do.

maxbritto commented 1 year ago

If you want to accept it, here is the PR : https://github.com/matanshukry/flutter_google_places_sdk/pull/59

maxbritto commented 1 year ago

@matanshukry : you can now close this one after 0.3.7