search

matanshukry / flutter_google_places_sdk

Flutter plugin for google places native sdk
32 stars 68 forks source link

Fix for typesFilter on findAutocompletePredictions #59

Closed maxbritto closed 9 months ago

maxbritto commented 9 months ago

Google changed the typesFilter options to receive a list of strings instead of a single enum value. They are really picky about the expected strings filter received. This patch should fix the implementation for the Android, iOS, http and web platforms.

Bugs related : https://github.com/matanshukry/flutter_google_places_sdk/issues/55 https://github.com/matanshukry/flutter_google_places_sdk/issues/48 https://github.com/matanshukry/flutter_google_places_sdk/issues/57

maxbritto commented 9 months ago

Sure, no problem. I'm not in a rush since I moved to my fork until you merge the PR.

Just one question : how do you test the lib locally ? I had to replace all the dependencies from version numbers to local paths, in each pubspec file, just to be able to build and use the local version. This can't be the right process, right ?

matanshukry commented 9 months ago

@maxbrittoSort of; I had to replace all the version numbers to local path as well, but you only have to do it in 1 place, using dependency_overrides, rather than go to each one and replace it in each of them.

It was either in the main sdk or in the example of it, don't remember now.

matanshukry commented 9 months ago

@maxbritto Implemented and published all. New sdk version is 0.3.7

And thanks for the contribution and the help!

maxbritto commented 9 months ago

You're welcome, glad I could help and thanks for the lib!