matanshukry / flutter_google_places_sdk

Flutter plugin for google places native sdk
32 stars 68 forks source link

Upgrade to GooglePlaces 8.5.0 and google_maps 7.1.0 #78

Closed fleoparra closed 2 months ago

fleoparra commented 3 months ago

Google Places works on ios 14 without problem. ios was downgraded from 15 to 14 introduced in commit 85ad330. GooglePlaces was upgraded from 8.3.0 to 8.5.0. Because of a dependency was necessary to upgraded google_maps on web to 7.1.0. This fix #75

stsc3000 commented 2 months ago

👋 Awesome, @fleoparra.

@matanshukry I think we need this for two reasons:

aggeloskoutanis commented 2 months ago

@stsc3000 What you mentioned is still a problem in version 2.6.1. Does anyone know when this is going to be fixed?

larry-cariq commented 2 months ago

@fleoparra Thanks for this PR as this will solve my problem with GooglePlaces 8.5.0 and iOS 14.0.

@matanshukry Do you know when the package flutter_google_places_sdk_ios will be updated to include this?

matanshukry commented 2 months ago

@aggeloskoutanis @larry-cariq @fleoparra @stsc3000

Published the iOS package under version 0.1.5, and the sdk (user-facing) package with the new 0.1.5 endorsed in version 0.3.8

stsc3000 commented 2 months ago

Thank you, @matanshukry 🎉

stsc3000 commented 2 months ago

@matanshukry Thanks for your work. We still seem to have a conflict regarding the google_maps dependency in flutter_google_places_sdk_web. Does _web still require a release?

matanshukry commented 2 months ago

@stsc3000 I missed the change to the web, I didn't even test it. It should have been in a different commit.

Anyway will check it out now

matanshukry commented 2 months ago

@stsc3000 done; updated web to 0.1.7, and sdk to endorse it at 0.3.9

stsc3000 commented 2 months ago

Thanks again, @matanshukry!