search

matanshukry / flutter_google_places_sdk

Flutter plugin for google places native sdk
36 stars 74 forks source link

Upgrade to AGP 8.2.2 and Kotlin to 1.9.22 #83

Closed fleoparra closed 4 months ago

fleoparra commented 4 months ago

This pull request fixes issue #71. In newer versions of Flutter, it is necessary to add the following to the android/build.gradle file:

kotlinOptions {
    jvmTarget = '1.8'
}

Additionally, the Android Gradle Plugin (AGP) has been upgraded to version 8.2.2, and Kotlin has been updated to version 1.9.22. The minSdk version is now 21, and the target SDK version is 34. There is another pull request, #82, which is similar but also upgrades Java and requires API level 23 and higher. For that reason I made a new pull request with minSdk on 21

AristideVB commented 4 months ago

Hello @fleoparra thanks for pointing this out I've lowered the minSDKVersion to 21, please feel free to close your PR in favor https://github.com/matanshukry/flutter_google_places_sdk/pull/82 🙂

I'd also would like to point out that you are mistaken in your PR name Upgrade to AGP 8.5 and Kotlin to 1.9.22 #83 since AGP 8.5 isn't out yet, what you have done is upgrade AGP to version 8.2.2 and Gradle to version 8.5 🙂

fleoparra commented 4 months ago

I close this PR in favor of #82