search

matatk / landmarks

Allows you to navigate a web page via WAI-ARIA landmarks, using the keyboard or a pop-up menu
http://matatk.agrip.org.uk/landmarks/
MIT License
125 stars 7 forks source link

Can the "guessing" feature be toggled on an off #457

Closed fstorr closed 3 years ago

fstorr commented 3 years ago

Hi

Can the new "trying to guess the landmark" feature be toggled on and off please? I use the extension for auditing so need to show just the actual landmarks on the page rather than ones that might exist.

Thanks

matatk commented 3 years ago

Hi @fstorr (and those of you who've provided feedback via reactions), and sorry for the slow reply. First of all, please note that any guessed landmark will have " (guessed)" appended to its label, and the border will be dashed instead of solid, so I hope that helps to a degree.

It would be fairly easy to add an option to disable the guessing entirely. I am generally against adding options unless there's a really strong case for them (to keep things simple) but it seems like a good idea in this case, so I'll work on it. The next question then is whether it's exposed in the options page, or just in the DevTools. I imagine making a "Developer" section in the options page is the simplest and most easily-discoverable way to go, so will try that first and see how it looks.

Thanks for your feedback :-).

matatk commented 3 years ago

I've added an option for this, which has closed this bug. I'll make a new release with this code included as soon as I can (most likely this week). Thanks again for your feedback.