search

matbesancon / MathOptSetDistances.jl

Distances to sets for MathOptInterface
MIT License
24 stars 4 forks source link

[RFC] add feasibility checker #12

Closed joaquimg closed 3 years ago

joaquimg commented 3 years ago

This might end up in a separate package.

It is a possible solution for https://github.com/jump-dev/JuMP.jl/issues/693

codecov[bot] commented 3 years ago

Codecov Report

Merging #12 (0aede64) into master (b7351d2) will decrease coverage by 7.41%. The diff coverage is 92.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
- Coverage   87.34%   79.93%   -7.42%     
==========================================
  Files           5        5              
  Lines         332      294      -38     
==========================================
- Hits          290      235      -55     
- Misses         42       59      +17
Impacted Files Coverage Δ
src/MathOptSetDistances.jl 100.00% <ø> (ø)
src/feasibility_checker.jl 92.72% <92.72%> (ø)
src/distances.jl 50.00% <0.00%> (-25.00%) :arrow_down:
src/projections.jl 89.00% <0.00%> (-11.00%) :arrow_down:
src/distance_sets.jl 68.93% <0.00%> (-3.91%) :arrow_down:
src/chainrules.jl

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b7351d2...eb72514. Read the comment docs.

matbesancon commented 3 years ago

Maybe adding docstrings on the functions to see what they are meant to be used for / be doing

matbesancon commented 3 years ago

re-opening PR to run on actions

matbesancon commented 3 years ago

I'm not sure about this conflict resolution, feel free to revert if it caused more damage than good

matbesancon commented 3 years ago

ok definitely broke something :grimacing:

joaquimg commented 3 years ago

I am writing version 2.0. Will update soon!

joaquimg commented 3 years ago

so... I moved it here: https://github.com/joaquimg/FeasibilityOptInterface.jl/pull/1 It grew a little too much and went beyond the scope of this package.