Closed tjdiamandis closed 3 years ago
Merging #43 (b559e68) into master (3a8ccf8) will increase coverage by
0.81%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #43 +/- ##
==========================================
+ Coverage 89.53% 90.34% +0.81%
==========================================
Files 6 6
Lines 449 466 +17
==========================================
+ Hits 402 421 +19
+ Misses 47 45 -2
Impacted Files | Coverage Δ | |
---|---|---|
src/distance_sets.jl | 74.05% <100.00%> (+1.79%) |
:arrow_up: |
src/projections.jl | 98.87% <100.00%> (+0.09%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 3a8ccf8...b559e68. Read the comment docs.
that's awesome! Do the differentiation for the projection match the heuristics in all cases?
The differentiation should be calling these heuristics too. I just moved the heuristic code to the case 4 function. Thanks for the catch!
Addresses #37 by adding heuristics in Henrik Friberg's paper
Also fixes small bug in
distance_to_set