Closed akshay326 closed 4 years ago
The general rule for which distance to implement: whenever you can
Fixes #4
A good property to test for all sets: The distance_to_set of the projection should always be 0
the docstring changes can be applied everywhere (in all docstrings)
Overall, I am not sure the dual argument is necessary, if people need the projection on the dual, they can just
project(dist, z, dual(s))
this will also simplify some functions IMO
bump :)
See codecov comments for where to add tests
add test for projections and gradients
actually this was useful: found and fixed a bug in one of the projection methods
Codecov Report
100.00% <ø> (ø)
50.00% <0.00%> (-25.00%)
66.66% <ø> (ø)
88.29% <88.29%> (ø)
Continue to review full report at Codecov.