matbesancon / MathOptSetDistances.jl

Distances to sets for MathOptInterface
MIT License
24 stars 4 forks source link

Fix RotatedSecondOrderCone NormedEpigraphDistance #78

Closed odow closed 1 year ago

odow commented 1 year ago

Looks like the last term was missing a max(..., zero(T))?

codecov[bot] commented 1 year ago

Codecov Report

Merging #78 (9be2cba) into master (dc93010) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #78   +/-   ##
=======================================
  Coverage   87.44%   87.44%           
=======================================
  Files           7        7           
  Lines         709      709           
=======================================
  Hits          620      620           
  Misses         89       89           
Files Coverage Δ
src/distance_sets.jl 75.43% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

matbesancon commented 1 year ago

did an example break? And/or should one be added?

odow commented 1 year ago

I'm adding some variants to MOI, and I noticed this. Didn't test yet

matbesancon commented 1 year ago

but yes the addition makes sense, something forgotten on my end