3 color scheme - Githubissues

match4everyone / match4everything

Other

7 stars 0 forks source link

3 color scheme #192

Closed bjrne closed 3 years ago

bjrne commented 3 years ago

Works towards #3

Changes:

correctly compile and include scss files with variables
use scss variables for all hardcoded style colors, apart from background colors and inline style blocks
replace btn blue with btn btn-primary

TODO in next PRs:

styles aus htmls raus
nach rgba suchen und ggf ersetzen durch vars
wie machen wir Farben in password_set_email.html modular
unify slightly varying background colors and use scss vars
clean css structure further

bjrne commented 3 years ago

Since this will be a huge chance in the end, lets divide this into several PRs in order to enable better review, faster merges and less merge conflicts :tada:

feeds commented 3 years ago

A lot of blue to primary ... should only malte review this?

bjrne commented 3 years ago

Noooo, please go ahead :) I did the structural changes together with Malte yesterday, so even better if someone else reviews this :)

For minor technicalities regarding css, there will be many possibilities to correct in future PRs.

feeds commented 3 years ago

Here I still see the old colors (set in map.js)

feeds commented 3 years ago

Good that I know where to click ;)

bjrne commented 3 years ago

Invisible buttons were a cache issue, map legend icons will be changed in next PRs.