match4everyone / match4everything

Other
7 stars 0 forks source link

3 - the filter ecosystem evolved #196

Closed feeds closed 3 years ago

feeds commented 4 years ago

Fixes #195 Fixes #170 Fixes #61 Fixes #176 Closes #37 Closes #188

Baschdl commented 4 years ago

I am able to try to send mails as not-logged-in user which luckily fails. But if it's intended that a user can see the filter page, maybe we should not show the contact option. image

Baschdl commented 4 years ago

I can contact new matches and get a positive feedback even if there aren't any new matches. image It even appears as a contact: image

Baschdl commented 4 years ago

Did the "Share mail" with institutions-button come from user feedback (a.k.a. is this really a useful feature)? Does this mean that a user only gets the mails from institutions after clicking this button?

feeds commented 4 years ago

idea was first to somehow track wether the first contact was successful to give e. g. institutions a better overview over who they contacted (i think this was user feedback). So we thought of linking this 'share email field' int he email.

but on second thought idea could be to generate a direct link under the message to the requested user that opens the response form that already exists (when you klick on 'message') Then we can register this in our system and afterwarda email contact is without us

feeds commented 4 years ago

with regards to permissions: i did not waste a thought on that, as I said before, until all other permissions are cleae and the relevant decorators are available

feeds commented 4 years ago

for seeing the filter list of oneselfb (send email fails)

i wanted to get some input here - i think it would be good to ba able for B to see the filter with which A contacted it but not search with it (=> would need a static view of the persistent filter)

maltezacharias commented 4 years ago

Will review tonight, please don't merge until tomorrow

feeds commented 4 years ago

Done

Todo

Other people:

Later