match4everyone / match4everything

Other
7 stars 0 forks source link

Automatically generate favicon from logo.svg #204

Closed bjrne closed 3 years ago

bjrne commented 3 years ago

We now generate all favicon sizes and the matching meta tags automatically during the webpack build process.

Since the icons are generated on every run, I ignored them in git, since are regenerated easily and there might be bit-level differences on different machines due to varying library version, OSes, ...

Open TODOs:

bjrne commented 3 years ago

Please review again @maltezacharias, I hope I have adressed all points (at least travis runs through now).

Please don't merge yet, I will add documentation for this once we decide it is the right way to do it.

When duplicating the logo, I was wondering why we still have all out image files in the backend folder - wouldn't it make more sense to put them into the frontend, now that we have it? And then have a build rule that copies them into the dist folder. This would

What do you think?