Completed TODO(@CarlosACJ55): Improve handling of entry points.
@seoyoungcho213 : Implemented cookie after login
Usage
Same run as usual. User should see no difference.
Changes
@CarlosACJ55
Refactored an new global and handler for public resources. Then served it withClientTimeout like all other handlers.
Refactored users structure to be visible from internal packages.
Added unit tests for new database APIs
Modified user verification to return user id and save unnecesary querying
@seoyoungcho213
Implemented cookie after login
Rationale
@CarlosACJ55
Were part of a TODO, were necessary improvements to get closer to completing the users management.
@seoyoungcho213
Implementing cookies & sessions
Dependencies
N/A
Issues and Bugs
Sign up redirects still don't work.
Unit tests really need to be more ppurposeful when using t.Fatal vs t.Error, must look over this file in the future
Currently using sprintf for a lot of queries, if we do this we must create tables of allowable values, then check our inuts to sprint before running any queries
Possible Solutions
If the login button is causing mad warinings, make sure to drop ur old schema!
Fix sign-up handler
Additional Notes
None
Contributors:
@CarlosACJ55, @seoyoungcho213
Name and what they did: All
Checklist before submitting
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation (if applicable).
[x] My changes generate no new warnings or errors.
[x] I have added tests that prove my fix is effective or that my feature works.
[x] New and existing unit tests pass locally with my changes.
[x] I have checked my code and corrected any misspellings.
[x] I have confirmed that my PR is targeting the correct branch.
[x] I understand that after merging, my branch may be deleted to keep the repository clean.
[x] I have notified the team with the status of my PR.
[x] If merge conflicts occur I will confer with other members of the team on how to proceed.
Other than the 2 bugs that were found and can be fixed in the next update this PR is good to go, and adds the required feature.
Good work @CarlosACJ55 @seoyoungcho213
Purpose
Completed TODO(@CarlosACJ55): Improve handling of entry points. @seoyoungcho213 : Implemented cookie after login
Usage
Same run as usual. User should see no difference.
Changes
@CarlosACJ55 Refactored an new global and handler for public resources. Then served it withClientTimeout like all other handlers. Refactored users structure to be visible from internal packages. Added unit tests for new database APIs Modified user verification to return user id and save unnecesary querying
@seoyoungcho213 Implemented cookie after login
Rationale
@CarlosACJ55 Were part of a TODO, were necessary improvements to get closer to completing the users management.
@seoyoungcho213 Implementing cookies & sessions
Dependencies
N/A
Issues and Bugs
Sign up redirects still don't work.
Unit tests really need to be more ppurposeful when using t.Fatal vs t.Error, must look over this file in the future
Currently using sprintf for a lot of queries, if we do this we must create tables of allowable values, then check our inuts to sprint before running any queries
Possible Solutions
If the login button is causing mad warinings, make sure to drop ur old schema!
Fix sign-up handler
Additional Notes
None
Contributors:
@CarlosACJ55, @seoyoungcho213 Name and what they did: All
Checklist before submitting