28 implement mysql database v2 - Githubissues

matcha-devs / matcha

A comprehensive web-based personal finance tracker and budgeting tool.

6 stars 0 forks source link

28 implement mysql database v2 #31

Closed seoyoungcho213 closed 4 months ago

seoyoungcho213 commented 4 months ago

Rationale

Implemented new MySQL database design based on our meeting.

Usage

Follow the existing pattern in database.go for the new tables design in the future

Changes

Non-trivial Files

New tables created : refer to the image above
For users table, removed username and added first-middle-last names and DOB.
Changed functions' arguments, unit-test, frontend pages accordingly to the new users table.

Testing

[x] ➕ Added units to existing tests
[ ] 🐣 Started a new group of tests
[ ] 🙅 New tests aren't needed
[ ] 🙋 Need help to add tests

Dependencies

N/A

Documentation Changes

[ ] 📜 README.md
[ ] 💬 Added necessary comments to existing code
[x] 🙅 no documentation needed

Issues and Bugs

didn't edit 'gen_users.sql' for new changes
Date of Birth doesn't add hypen automatically & takes string (need to only take numbers)

Possible Solutions

change 'gen_users.sql' based on new users table format
change frontend side to only take numbers in DOB (+ no future date) and add hypen based on the format (YYYY-MM-DD)

Additional Notes

GetUserID() might not be useful anymore because of cookie, and we are returning id, err after AddUser() from this change.

seoyoungcho213 commented 4 months ago

Due to #12 , I changed expected ID (3) to (4) in mysql_test.go.