matchai / spacefish

🚀🐟 The fish shell prompt for astronauts
https://spacefish.matchai.dev
MIT License
963 stars 79 forks source link

Vi-mode Feature Implementation #103

Closed kulabun closed 5 years ago

kulabun commented 5 years ago

Vi-mode Feature Implementation

Description

Implements Vi-Mode Feature. There are some difference with zsh's spaceship implementation:

Also I have overridden default fish_mode_prompt to avoid duplication. I think it better to have it all out of box.

Motivation and Context

74

Types of changes

Screenshots (if appropriate):

How Has This Been Tested?

Checklist:

kulabun commented 5 years ago

Hey @matchai , Thanks for your time spent to review this PR. Fixed it all.

kulabun commented 5 years ago

Wow, that's interesting. After my commit CI start failing with this:

not ok 142 Prints section when fish_vi_key_bindigs is set

operator: = expected: ' [I] ' received: ' [N] ' ...

Unfortunately right after running fish_vi_key_bindings CI have fish_bind_mode in 'normal' state instead of 'insert'.

Fixed it.